Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disconnect GKE operators from deprecated hooks #39434

Merged
merged 2 commits into from
May 8, 2024
Merged

Disconnect GKE operators from deprecated hooks #39434

merged 2 commits into from
May 8, 2024

Conversation

moiseenkov
Copy link
Contributor

This PR refactors GKE operators through replacing deprecated hooks with refactored GKE hooks.

@boring-cyborg boring-cyborg bot added area:providers provider:cncf-kubernetes Kubernetes provider related issues provider:google Google (including GCP) related issues labels May 6, 2024
@moiseenkov moiseenkov force-pushed the gke/refator-hooks branch 2 times, most recently from b8fe94e to 069cc10 Compare May 6, 2024 14:21
@Taragolis
Copy link
Contributor

Could you also remove tests from the ignore list, for details you could have a look at #38642)

I guess at least these could be removed

tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEDeleteJobOperator::test_default_gcp_conn_id
tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEDeleteJobOperator::test_gcp_conn_id
tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEDescribeJobOperator::test_default_gcp_conn_id
tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEDescribeJobOperator::test_gcp_conn_id
tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEStartJobOperator::test_default_gcp_conn_id
tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEStartJobOperator::test_gcp_conn_id
tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEStartKueueInsideClusterOperator::test_execute
tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEStartKueueJobOperator::test_default_gcp_conn_id
tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEStartKueueJobOperator::test_gcp_conn_id

@moiseenkov
Copy link
Contributor Author

Could you also remove tests from the ignore list, for details you could have a look at #38642)

I guess at least these could be removed

tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEDeleteJobOperator::test_default_gcp_conn_id
tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEDeleteJobOperator::test_gcp_conn_id
tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEDescribeJobOperator::test_default_gcp_conn_id
tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEDescribeJobOperator::test_gcp_conn_id
tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEStartJobOperator::test_default_gcp_conn_id
tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEStartJobOperator::test_gcp_conn_id
tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEStartKueueInsideClusterOperator::test_execute
tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEStartKueueJobOperator::test_default_gcp_conn_id
tests/providers/google/cloud/operators/test_kubernetes_engine.py::TestGKEStartKueueJobOperator::test_gcp_conn_id

Sure! Thanks for the suggestion. I removed tests that stopped failing after refactoring.

@moiseenkov
Copy link
Contributor Author

@Taragolis , @potiuk , hi
Could you please take a look? Thank you

@potiuk potiuk merged commit 62b845e into apache:main May 8, 2024
39 checks passed
@potiuk
Copy link
Member

potiuk commented May 8, 2024

Nice!

RodrigoGanancia pushed a commit to RodrigoGanancia/airflow that referenced this pull request May 10, 2024
@moiseenkov @RodrigoGanancia
Disconnect GKE operators from deprecated hooks (apache#39434)
5c9f12d 
* Disconnect GKE operators from deprecated hooks

* Remove GKE unit tests from deprecation ignore list
@eladkal eladkal mentioned this pull request May 12, 2024
Closed
66 tasks
pateash pushed a commit to pateash/airflow that referenced this pull request May 13, 2024
@moiseenkov @pateash
Disconnect GKE operators from deprecated hooks (apache#39434)
b71bc89 
* Disconnect GKE operators from deprecated hooks

* Remove GKE unit tests from deprecation ignore list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@dirrao dirrao dirrao approved these changes

Assignees
No one assigned
Labels
area:providers provider:cncf-kubernetes Kubernetes provider related issues provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moiseenkov @Taragolis @potiuk @dirrao